Remove use of deprecated net.Error.Temporary() #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is deprecated in 1.18 and picked up as an error in newer versions of golangci-lint (at least since 1.45.2 and beyond).
Tristan-Wilson
requested review from
hkalodner,
PlasmaPower,
joshuacolvin0 and
tsahee
auto-merge was automatically disabled
March 28, 2022 21:03
Rebase failed
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
==========================================
+ Coverage 48.47% 48.50% +0.03%
==========================================
Files 168 168
Lines 17510 17510
Branches 458 458
==========================================
+ Hits 8488 8494 +6
+ Misses 7802 7793 -9
- Partials 1220 1223 +3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is deprecated in 1.18 and picked up as an error in newer versions
of golangci-lint (at least since 1.45.2 and beyond).
Timeout() cover a subset of the errors in Temporary() so it should be safe in this case because I think the intent of the code is to retry on recoverable errors. See discussion of the deprecation here: golang/go#45729