Adds more tests related to precompiles #2709
Open
+532
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It only calls util.RemapL1Address, that is covered in other test flows
It basically uses AddressSet.RectifyMapping that is already covered in other tests
cla-bot
bot
added
the
s
eljobe
requested changes
Sep 30, 2024
| "github.com/offchainlabs/nitro/util/testhelpers" | ||
| ) | ||
|
|
||
| func TestArbGasInfo(t *testing.T) { |
There was a problem hiding this comment.
This feels like it's actually checking several different calls in the same test. But, I can't tell if the results of the later calls actually depend on the results of the earlier calls. In many cases, it looks like they are unrelated. If so, they should be in separate test functions to make it clearer which part of the test is failing, and to make the setup for the test clearly connect to the assertions in the test.
| @@ -125,6 +142,184 @@ func TestPrecompileErrorGasLeft(t *testing.T) { | |||
| assertNotAllGasConsumed(common.HexToAddress("0xff"), arbDebug.Methods["legacyError"].ID) | |||
| } | |||
|
|
|||
| func TestArbGasInfoAndArbOwner(t *testing.T) { | |||
There was a problem hiding this comment.
Same feedback about doing too much in the same test function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves NIT-2772.
Improve precompiles' test coverage.
Other precompiles methods from ArbOwner, ArbWasm, and ArbWasmCache, are tested in a PR from @ganeshvanahalli.