stylus: add compilation target config, support multiple targets in wasm store #2463
Conversation
also introduce compilation target
cla-bot
bot
added
the
s
| @@ -56,17 +55,21 @@ pub fn target_cache_set(name: String, description: String, native: bool) -> Resu | |||
| } | |||
| return Err(eyre!(err_message)); | |||
| } | |||
| InitCache::set_target(target.clone()) | |||
| *TARGET_NATIVE.write() = target.clone(); | |||
There was a problem hiding this comment.
I'd still add a comment to target_cache_set explaining everything this function does, because it kind of does two things in one. It both populates TARGET_CACHE, but if native is set, it also populates TARGET_NATIVE which isn't really a cache or related to TARGET_CACHE.
There was a problem hiding this comment.
added a following comment:
/// Populates `TARGET_CACHE` inserting target specified by `description` under `name` key.
/// Additionally, if `native` is set it sets `TARGET_NATIVE` to the specified target.
Let me know if that's good / precise enough :)
|
The docker build seems to be failing with
and it's not failing on master https://github.com/OffchainLabs/nitro/actions/runs/10423011222/job/28868789568 Did we accidentally introduce a new wasmer-go dependency? |
|
It looks like it's from |
Resolves: NIT-2631
Resolves: NIT-2695
This PR:
Based on: #2417
Pulls: OffchainLabs/go-ethereum#339