Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sequencer inbox isSequencer to verify feed signatures #1630

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

PlasmaPower
Copy link
Collaborator

Pulls in OffchainLabs/nitro-contracts#3

This code is all @magicxyyz's, but I had to make a new commit with the code because git doesn't handle merge conflicts between a folder and a submodule well.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #1630 (900223e) into master (be635cf) will increase coverage by 0.13%.
The diff coverage is 38.66%.

@@            Coverage Diff             @@
##           master    #1630      +/-   ##
==========================================
+ Coverage   28.31%   28.44%   +0.13%     
==========================================
  Files         218      218              
  Lines       32846    32853       +7     
==========================================
+ Hits         9301     9346      +45     
+ Misses      22481    22456      -25     
+ Partials     1064     1051      -13     

joshuacolvin0
joshuacolvin0 previously approved these changes Sep 28, 2023
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit eb54048 into master Sep 28, 2023
9 checks passed
@joshuacolvin0 joshuacolvin0 deleted the is-sequencer-feed branch September 28, 2023 07:42
@AiyAbuya AiyAbuya mentioned this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants