Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IPFS kubo and support Go 1.20 #1596

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Update IPFS kubo and support Go 1.20 #1596

merged 3 commits into from
Apr 27, 2023

Conversation

PlasmaPower
Copy link
Collaborator

The particular dependency that got me before was github.com/ipfs/go-ipfs-files which has been moved to github.com/ipfs/go-libipfs/files. Depending on the former was pulling in other out of date dependencies that broke the whole build. I've replaced it with the newer version and upgraded all the IPFS dependencies to their latest versions.

I'm not updating Go in CI yet because Arbitrator doesn't support Go 1.20 until #1551

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #1596 (6b575c1) into master (6a87ba6) will increase coverage by 1.32%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #1596      +/-   ##
==========================================
+ Coverage   53.27%   54.60%   +1.32%     
==========================================
  Files         281      221      -60     
  Lines       35911    32951    -2960     
  Branches      555        0     -555     
==========================================
- Hits        19133    17992    -1141     
+ Misses      14615    12790    -1825     
- Partials     2163     2169       +6     

magicxyyz
magicxyyz previously approved these changes Apr 27, 2023
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 63112e4 into master Apr 27, 2023
@PlasmaPower PlasmaPower deleted the update-ipfs branch April 27, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants