Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IsSequencer mapping #1433

Merged
merged 6 commits into from
Jan 13, 2023
Merged

Use IsSequencer mapping #1433

merged 6 commits into from
Jan 13, 2023

Conversation

magicxyyz
Copy link
Contributor

Use IsSequencer mapping from SequencerInbox contract to validate sequencer feed signer.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jan 11, 2023
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #1433 (468e9c8) into contracts-develop (9b48858) will decrease coverage by 3.89%.
The diff coverage is 62.22%.

❗ Current head 468e9c8 differs from pull request most recent head 543d786. Consider uploading reports for the commit 543d786 to get more accurate results

@@                  Coverage Diff                  @@
##           contracts-develop    #1433      +/-   ##
=====================================================
- Coverage              52.29%   48.39%   -3.90%     
=====================================================
  Files                    260      248      -12     
  Lines                  34120    30036    -4084     
  Branches                 555      555              
=====================================================
- Hits                   17842    14535    -3307     
+ Misses                 14200    13421     -779     
- Partials                2078     2080       +2     

Base automatically changed from sequencer-inbox-is-sequencer to contracts-develop January 13, 2023 01:05
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 481096d into contracts-develop Jan 13, 2023
@hkalodner hkalodner deleted the address-verifier branch January 19, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants