Add isSequencer mapping to SequencerInbox #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
PlasmaPower
reviewed
Jan 9, 2023
Codecov Report
@@ Coverage Diff @@
## contracts-develop #1424 +/- ##
=====================================================
+ Coverage 48.38% 52.29% +3.90%
=====================================================
Files 245 260 +15
Lines 29528 34120 +4592
Branches 555 555
=====================================================
+ Hits 14287 17842 +3555
- Misses 13196 14200 +1004
- Partials 2045 2078 +33 |
gzeoneth
requested changes
Jan 11, 2023
Comment on lines
160
to
162
| * @notice Updates whether an address is authorized to be a sequencer at the sequencer inbox | ||
| * @param addr the address | ||
| * @param isSequencer_ if the specified address should be authorized as a sequencer |
There was a problem hiding this comment.
I think we should add a @dev here that this is not validated onchain right now.
There was a problem hiding this comment.
I added a dev comment describing briefly where the IsSeqeuncer information is used. Please let me know if that's what you had in mind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add isSequencer mapping in the SequencerInbox for feed message signing (and possibly redis signing)