feat: allow rollup update #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvladika
previously approved these changes
Oct 24, 2023
yahgwai
previously approved these changes
Oct 24, 2023
| @@ -789,6 +802,44 @@ describe('ArbRollup', () => { | |||
| await rollup.confirmNextNode(challengerNode) | |||
| }) | |||
|
|
|||
| it('allow force refund staker with pending node', async function () { | |||
| await rollupAdmin.connect(await impersonateAccount(upgradeExecutor)).pause() | |||
There was a problem hiding this comment.
missing .wait() - and on some other transactions below
There was a problem hiding this comment.
that should not be necessary right? otherwise the test should be failing
There was a problem hiding this comment.
could just be getting lucky with timing. You might get intermittent failures with this
yahgwai
approved these changes
Oct 24, 2023
gvladika
approved these changes
Oct 24, 2023
This was referenced Oct 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR included 2 changes that should only affect privileged methods
Allow rollup admin to update rollup addresses in Bridge contracts, and synchronizing those changes to Outbox, RollupEventInbox, and Sequencer Inbox. These changes are audited as part of BOLD in Added upgrade action for the bold upgrade bold#340 but for proxy admin instead of rollup admin. Allowing rollup admin to call those function make the upgrade executor being able to call those function easier (or otherwise would require a upgradeAndCall via the ProxyAdmin contract).
Introduce
whenNotPausedOrDeprecatedmodifier, which allow validator to withdraw their stake when the rollup is deprecated by changing the rollup address in the bridge to something elseSuperseding