Fix the BridgeCreator.sol contract #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up the code and reduce deployment gas cost by moving contract creation outside of the contructor. Move the sequencer inbox maxTimeVariation from memory to calldata. Index the sender for MessageDelivered events - this allows bridges to efficiently query the deposit history for an address without requiring an external indexer. Add DISABLE_VERIFICATION environment variable to disable contract verification.
remove indexed variable change - this can be done in a separate pr as it breaks the abi remove RollupCreator.BridgeContracts - use the BridgeCreator.BridgeContracts struct instead make BridgeCreator.createBridge() return a BridgeContracts struct instead of a tuple fix unit tests run "yarn format" to clean up the code
This was referenced Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick commits from https://github.com/tsite/nitro-contracts/tree/feature-orbit-bridge
Clean up the code and reduce deployment gas cost by moving contract creation outside of the contructor.
Move the sequencer inbox maxTimeVariation from memory to calldata.
Add DISABLE_VERIFICATION environment variable to disable contract verification.