check for empty validator set and zero address for batch poster #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzeoneth
reviewed
Jul 13, 2023
src/rollup/RollupCreator.sol
Outdated
Comment on lines
66
to
68
| // Validators and batch poster should be set if provided | ||
| // If you don't want to set validators, put an empty list | ||
| // If you don't want to set batch-poster, put zero address |
There was a problem hiding this comment.
can you replace the whole comment with
/**
* @notice Create a new rollup
* @dev After this setup:
* @dev - Rollup should be the owner of bridge
* @dev - RollupOwner should be the owner of Rollup's ProxyAdmin
* @dev - RollupOwner should be the owner of Rollup
* @dev - Bridge should have a single inbox and outbox
* @dev - Validators and batch poster should be set if provided
* @param config The configuration for the rollup
* @param _batchPoster The address of the batch poster, not used when set to zero address
* @param _validators The list of validator addresses, not used when set to empty list
* @return The address of the newly created rollup
*/
gzeoneth
approved these changes
Jul 13, 2023
Merged
gzeoneth
pushed a commit
that referenced
this pull request
Apr 23, 2024
Optimize Function Merklization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.