Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: explain arbOSVersion offset #245

Merged
merged 4 commits into from
Sep 12, 2024
Merged

docs: explain arbOSVersion offset #245

merged 4 commits into from
Sep 12, 2024

Conversation

gzeoneth
Copy link
Member

@gzeoneth gzeoneth commented Sep 3, 2024 •
edited
Loading

https://github.com/OffchainLabs/nitro/blob/30312346fcf681351b819548d9b03fd751fbc639/precompiles/ArbSys.go#L64

	version := new(big.Int).SetUint64(55 + c.State.ArbOSVersion()) // Nitro starts at version 56

@cla-bot cla-bot bot added the s label Sep 3, 2024
gvladika
gvladika approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@gvladika gvladika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@gzeoneth gzeoneth merged commit 2376ee7 into develop Sep 12, 2024
12 checks passed
@gzeoneth gzeoneth deleted the gzeoneth-patch-1 branch September 12, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvladika gvladika gvladika approved these changes

@yahgwai yahgwai Awaiting requested review from yahgwai

@godzillaba godzillaba Awaiting requested review from godzillaba

Assignees
No one assigned
Labels
s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gzeoneth @gvladika