-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to set alternative transferor #224
Conversation
Transferor storage currentTransferor = transferorOf[msg.sender]; | ||
if ( | ||
currentTransferor.addr != address(0) && | ||
currentTransferor.fixedUntilRound > roundTimingInfo.currentRound() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe its better to fix to a timestamp (and rounding up 1 round) instead? otherwise changing round time might make the fix duration change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's fine - round duration changes might also warrant a change of fix time. Also changing to timestamp might mean that you cant guarantee that the next round will have a fixed transferor
No description provided.