Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify address when caching Stylus program #194

Merged
merged 6 commits into from
Jul 1, 2024
Merged

Conversation

PlasmaPower
Copy link
Contributor

No description provided.

@PlasmaPower PlasmaPower requested a review from tsahee June 21, 2024 21:27
@cla-bot cla-bot bot added the s label Jun 21, 2024
joshuacolvin0
joshuacolvin0 previously approved these changes Jun 21, 2024
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tsahee
tsahee previously approved these changes Jun 22, 2024
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gzeoneth gzeoneth self-requested a review June 25, 2024 19:25
Copy link
Member

@gzeoneth gzeoneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, otherwise lgtm

src/chain/CacheManager.sol Show resolved Hide resolved
src/chain/CacheManager.sol Show resolved Hide resolved
gzeoneth
gzeoneth previously approved these changes Jun 25, 2024
@gzeoneth gzeoneth dismissed stale reviews from tsahee, joshuacolvin0, and themself via 40caf7c June 25, 2024 20:11
gzeoneth
gzeoneth previously approved these changes Jul 1, 2024
@gzeoneth gzeoneth enabled auto-merge July 1, 2024 18:21
@gzeoneth gzeoneth merged commit b8fd7cd into develop Jul 1, 2024
11 of 13 checks passed
@gzeoneth gzeoneth deleted the cache-program-address branch July 1, 2024 18:24
@gzeoneth gzeoneth mentioned this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants