Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 0x50 as the header byte for 4844 batches #118

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Use 0x50 as the header byte for 4844 batches #118

merged 2 commits into from
Jan 23, 2024

Conversation

PlasmaPower
Copy link
Contributor

This leaves other possibilities open for the DATA_AUTHENTICATED_FLAG.

Also renames addSequencerL2BatchFromBlob to addSequencerL2BatchFromBlobs (plural) since it can use multiple blobs.

@cla-bot cla-bot bot added the s label Jan 23, 2024
@PlasmaPower PlasmaPower mentioned this pull request Jan 23, 2024
Merged
gzeoneth
gzeoneth approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@gzeoneth gzeoneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gzeoneth gzeoneth merged commit 6822d51 into 4844-only Jan 23, 2024
5 checks passed
@gzeoneth gzeoneth deleted the 4844-0x50 branch January 23, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzeoneth gzeoneth gzeoneth approved these changes

@yahgwai yahgwai Awaiting requested review from yahgwai

Assignees
No one assigned
Labels
s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PlasmaPower @gzeoneth