Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set initial pricePerUnit #117

Merged
merged 25 commits into from
Jul 3, 2024
Merged

Set initial pricePerUnit #117

merged 25 commits into from
Jul 3, 2024

Conversation

gvladika
Copy link
Contributor

@gvladika gvladika commented Jan 22, 2024 •
edited by hkalodner
Loading

In case of custom fee token based chains, report 0 data cost in initial msg in order to set pricePerUnit to 0.

Fixes BLK-25

@gvladika
Report 0 batch poster spendings for rollups using custom fee token
902a4f7
@gvladika
Add unit test for fee token based chain
02075fc
@gvladika
Add test for arbitrum hosted ETH-based chain
600b090
@gvladika
Make it more readable
120065a
@gvladika
Add missing deployment block
8447048
@gvladika
Merge branch 'develop' into fee-token-reports
1698e1a
@gvladika
Report 0 data cost in init msg for fee token based chains
505c024
@gvladika
Add Foundry test for rollup event inbox, init function
87f3dde
@gvladika
Add rollupInitialized tests
396a26d
@gvladika
Check event MessageDelivered params
8dd2e18
@gvladika
Merge branch 'develop' into fee-token-reports
764c1b8
@gvladika
Instead of reporting 0 basefee, don't send report at all in case fee …
0e8e684 
…token is used
@gvladika
Merge branch 'fee-token-reports' of github.com:OffchainLabs/nitro-con…
e8b785b 
…tracts into fee-token-reports
@gvladika
Make 'isUsingFeeToken' immutable to avoid nativeToken() calls
4c994f6
@gvladika
Add constructor/initialization unit tests
deb18fb
@gvladika
Merge branch 'fee-token-reports' into init-price
6bc4de6
@cla-bot cla-bot bot added the s label Jan 22, 2024
Base automatically changed from fee-token-reports to develop January 24, 2024 15:14
@gzeoneth gzeoneth merged commit 7aae8fa into develop Jul 3, 2024
12 of 14 checks passed
@gzeoneth gzeoneth deleted the init-price branch July 3, 2024 13:30
@gzeoneth gzeoneth mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzeoneth gzeoneth gzeoneth approved these changes

@shotaronowhere shotaronowhere Awaiting requested review from shotaronowhere

Assignees
No one assigned
Labels
s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gvladika @gzeoneth