Blob data gas refunds #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlasmaPower
reviewed
Jan 17, 2024
yahgwai
force-pushed
the
4844-gas-refunder
branch
from
5443ca8
to
1ff97e2
Compare
PlasmaPower
approved these changes
Jan 17, 2024
gzeoneth
force-pushed
the
4844-gas-refunder
branch
from
c6a61e8
to
7e7f683
Compare
gzeoneth
force-pushed
the
4844-gas-refunder
branch
from
7e7f683
to
c5b6a78
Compare
gzeoneth
force-pushed
the
4844-only
branch
2 times, most recently
from
3961315
to
0e733fc
Compare
Formatting Updates for code review Remove whitespace Formatting
…ity with block basefee
gzeoneth
force-pushed
the
4844-gas-refunder
branch
from
c5b6a78
to
e6871c5
Compare
|
Sorry for the force-push spam, should be good now. |
gzeoneth
requested changes
Jan 18, 2024
gzeoneth
reviewed
Jan 18, 2024
shotaronowhere
suggested changes
Jan 18, 2024
There was a problem hiding this comment.
As gzeon mentioned, gas refunder in addSequencerL2BatchFromOrigin should be updated, but there is a stack too deep error with extra arguments for the modifier.
Plausibly refundsGas(x,y,z) could be refactored to refundsGas(x, bool refundBlob) or simply refundsGas(x), refundsGasWithBlob(x)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now refunds if there were blobs on the transaction