fix: unused import and visibility (#236)

* fix: lint issues

* fix: slither db

.solhint.json

@@ -12,6 +12,9 @@
     "not-rely-on-time": "off",
     "max-states-count": ["warn", 40],
     "no-inline-assembly": "off",
+    "no-global-import": "off",
+    "custom-errors": "off",
+    "immutable-vars-naming": "off",
     "var-name-mixedcase": "off"
   },
   "plugins": []

src/bridge/AbsInbox.sol

@@ -12,7 +12,6 @@ import {
     InsufficientSubmissionCost,
     L1Forked,
     NotAllowedOrigin,
-    NotOrigin,
     NotRollupOrOwner,
     RetryableData
 } from "../libraries/Error.sol";

src/bridge/Bridge.sol

@@ -11,8 +11,6 @@ import "./IEthBridge.sol";
 import "./Messages.sol";
 import "../libraries/DelegateCallAware.sol";
 
-import {L1MessageType_batchPostingReport} from "../libraries/MessageTypes.sol";
-
 /**
  * @title Staging ground for incoming and outgoing messages
  * @notice It is also the ETH escrow for value sent with these messages.

src/bridge/ERC20Bridge.sol

@@ -13,7 +13,6 @@ import {
     CallNotAllowed,
     NativeTokenDecimalsTooLarge
 } from "../libraries/Error.sol";
-import {DecimalsConverterHelper} from "../libraries/DecimalsConverterHelper.sol";
 import {MAX_ALLOWED_NATIVE_TOKEN_DECIMALS} from "../libraries/Constants.sol";
 
 import {IERC20} from "@openzeppelin/contracts/token/ERC20/IERC20.sol";

src/bridge/Inbox.sol

@@ -4,16 +4,7 @@
 
 pragma solidity ^0.8.4;
 
-import {
-    NotOrigin,
-    DataTooLarge,
-    InsufficientValue,
-    InsufficientSubmissionCost,
-    RetryableData,
-    L1Forked,
-    NotForked,
-    GasLimitTooLarge
-} from "../libraries/Error.sol";
+import {NotOrigin, NotForked, GasLimitTooLarge} from "../libraries/Error.sol";
 import "./AbsInbox.sol";
 import "./IInbox.sol";
 import "./IBridge.sol";
@@ -22,7 +13,6 @@ import "../libraries/AddressAliasHelper.sol";
 import {
     L2_MSG,
     L1MessageType_L2FundedByL1,
-    L1MessageType_submitRetryableTx,
     L1MessageType_ethDeposit,
     L2MessageType_unsignedEOATx,
     L2MessageType_unsignedContractTx

src/bridge/SequencerInbox.sol

@@ -7,7 +7,6 @@ pragma solidity ^0.8.0;
 import {
     AlreadyInit,
     HadZeroInit,
-    BadPostUpgradeInit,
     NotOrigin,
     DataTooLarge,
     DelayedBackwards,
@@ -45,7 +44,6 @@ import "../precompiles/ArbGasInfo.sol";
 import "../precompiles/ArbSys.sol";
 import "../libraries/IReader4844.sol";
 
-import {L1MessageType_batchPostingReport} from "../libraries/MessageTypes.sol";
 import "../libraries/DelegateCallAware.sol";
 import {IGasRefunder} from "../libraries/IGasRefunder.sol";
 import {GasRefundEnabled} from "../libraries/GasRefundEnabled.sol";

src/libraries/DecimalsConverterHelper.sol

@@ -4,8 +4,6 @@
 
 pragma solidity ^0.8.0;
 
-import {ERC20} from "@openzeppelin/contracts/token/ERC20/ERC20.sol";
-
 library DecimalsConverterHelper {
     /// @notice generic function for mapping amount from one decimal denomination to another
     /// @dev Ie. let's say amount is 752. If token has 16 decimals and is being adjusted to

src/rollup/AbsRollupEventInbox.sol

@@ -11,7 +11,6 @@ import "../precompiles/ArbGasInfo.sol";
 import "../libraries/ArbitrumChecker.sol";
 import "../bridge/IDelayedMessageProvider.sol";
 import "../libraries/DelegateCallAware.sol";
-import {INITIALIZATION_MSG_TYPE} from "../libraries/MessageTypes.sol";
 import {AlreadyInit, HadZeroInit, RollupNotChanged} from "../libraries/Error.sol";
 
 /**

src/rollup/ERC20RollupEventInbox.sol

@@ -6,6 +6,7 @@ pragma solidity ^0.8.0;
 
 import "./AbsRollupEventInbox.sol";
 import "../bridge/IERC20Bridge.sol";
+import {INITIALIZATION_MSG_TYPE} from "../libraries/MessageTypes.sol";
 
 /**
  * @title The inbox for rollup protocol events

src/rollup/RollupEventInbox.sol

@@ -6,6 +6,7 @@ pragma solidity ^0.8.0;
 
 import "./AbsRollupEventInbox.sol";
 import "../bridge/IEthBridge.sol";
+import {INITIALIZATION_MSG_TYPE} from "../libraries/MessageTypes.sol";
 
 /**
  * @title The inbox for rollup protocol events

src/rollup/RollupUserLogic.sol

@@ -10,7 +10,6 @@ import {IRollupUser} from "./IRollupLogic.sol";
 import "../libraries/UUPSNotUpgradeable.sol";
 import "./RollupCore.sol";
 import "./IRollupLogic.sol";
-import {ETH_POS_BLOCK_TIME} from "../libraries/Constants.sol";
 
 contract RollupUserLogic is RollupCore, UUPSNotUpgradeable, IRollupUser {
     using AssertionNodeLib for AssertionNode;

test/foundry/ERC20RollupEventInbox.t.sol

@@ -5,6 +5,7 @@ import "./AbsRollupEventInbox.t.sol";
 import {TestUtil} from "./util/TestUtil.sol";
 import {ERC20RollupEventInbox} from "../../src/rollup/ERC20RollupEventInbox.sol";
 import {ERC20Bridge, IERC20Bridge, IOwnable} from "../../src/bridge/ERC20Bridge.sol";
+import {INITIALIZATION_MSG_TYPE} from "../../src/libraries/MessageTypes.sol";
 import {ERC20PresetMinterPauser} from
     "@openzeppelin/contracts/token/ERC20/presets/ERC20PresetMinterPauser.sol";
 

test/foundry/RollupEventInbox.t.sol

@@ -5,6 +5,7 @@ import "./AbsRollupEventInbox.t.sol";
 import {TestUtil} from "./util/TestUtil.sol";
 import {RollupEventInbox, IRollupEventInbox} from "../../src/rollup/RollupEventInbox.sol";
 import {Bridge, IOwnable, IEthBridge} from "../../src/bridge/Bridge.sol";
+import {INITIALIZATION_MSG_TYPE} from "../../src/libraries/MessageTypes.sol";
 import "../../src/libraries/MessageTypes.sol";
 
 contract RollupEventInboxTest is AbsRollupEventInboxTest {