-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for wasm compile targets #339
Merged
Merged
Changes from 10 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
4027003
rawdb: add support for multiple compile targets
magicxyyz e0ac28c
map from target to asm
magicxyyz ee41c04
Merge branch 'master' into wasm-store-compile-target
magicxyyz 74bb00e
Merge branch 'master' into wasm-store-compile-target
magicxyyz b1a40de
improve error handling in TryGetActivatedAsmMap
magicxyyz c166c0b
Merge branch 'master' into wasm-store-compile-target
magicxyyz ff2a8bc
export WasmSchemaVersion
magicxyyz a67b1f8
unify apis for stylus modules (wavm) and native asms
magicxyyz c700dab
pass targetNames to StateDB.TryGetActivatedAsmMap
magicxyyz 04d7d72
fix StateDB.TryGetActivatedAsmMap
magicxyyz c4c2994
set wasm schema version to 0
magicxyyz 1086023
return early in RecordProgram if called with empty targetNames slice
magicxyyz 896fca1
rename targets X86 -> amd64 and arm -> arm64 (matching GOARCH)
magicxyyz bbbcec2
Revert "set wasm schema version to 0"
magicxyyz 7e37376
declare new type for target
magicxyyz 6976d72
use target type
magicxyyz c359493
add string decoding/encoding for rawdb.Target
magicxyyz e09c6f8
rename ActivateWasm parameter
magicxyyz 034c335
fix joining errors in TryGetActivatedAsmMap
magicxyyz a75f682
add rawdb.Target.keyPrefix and rawdb.Target.IsValid
magicxyyz 01e2210
remove rawdb.TargetFromString and rawdb.Target.ToString
magicxyyz 5ed6b5f
return error from ReadWasmSchemaVersion
magicxyyz 59cf3e3
add rawdb.DeprecatedKeysV0
magicxyyz d055235
Merge branch 'master' into wasm-store-compile-target
magicxyyz aa44bd4
add LocalTarget() to rawdb, use LocalTarget() in EvictWasm.Revert
magicxyyz abc46c6
rename DeprecatedKeysV0 to DeprecatedPrefixesV0
magicxyyz 575062f
define WasmPrefix type as [3]byte
magicxyyz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not 100% certain - but I think maybe TargetArm and TargetAsm should be identical to the runtime.GOARCH on arm64/x86 architectures, which will be compatible with some exiting code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used GOARCH strings + I renamed the constants to TargetArm64 and TargetAmd64 to make it more consistent