Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arbitrum APIBackend's GetTransaction should return false when tx is not found #321

Merged
merged 1 commit into from
May 23, 2024
Merged

Arbitrum APIBackend's GetTransaction should return false when tx is not found #321

merged 1 commit into from
May 23, 2024

Conversation

ganeshvanahalli
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli commented May 23, 2024 •
edited
Loading

Resolves NIT-2544

@cla-bot cla-bot bot added the s label May 23, 2024
joshuacolvin0
joshuacolvin0 approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower mentioned this pull request May 23, 2024
Closed
@joshuacolvin0 joshuacolvin0 merged commit 021ff6f into master May 23, 2024
3 of 4 checks passed
@joshuacolvin0 joshuacolvin0 deleted the gettransaction-apibackend-bugfix branch May 23, 2024 23:31
pc-quiknode added a commit to quiknode-labs/nitro that referenced this pull request Jun 9, 2024
@pc-quiknode
cherry-picking OffchainLabs/go-ethereum#321
b479315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

@Tristan-Wilson Tristan-Wilson Awaiting requested review from Tristan-Wilson

Assignees
No one assigned
Labels
s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganeshvanahalli @joshuacolvin0