Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint CI job #230

Merged
merged 5 commits into from
Aug 9, 2023
Merged

Add lint CI job #230

merged 5 commits into from
Aug 9, 2023

Conversation

Tristan-Wilson
Copy link
Member

@Tristan-Wilson Tristan-Wilson commented Jun 9, 2023

This PR adds a lint CI job for our geth fork and fixes some minor issues found by the linter.

- Unused functions
- Unneeded conversions
- Mispellings
- Unnecessary whitespace
@Tristan-Wilson Tristan-Wilson marked this pull request as ready for review June 9, 2023 17:03
tsahee
tsahee previously approved these changes Jun 9, 2023
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tristan-Wilson
Copy link
Member Author

Setting back to draft til prerequisite PRs are merged.

@Tristan-Wilson Tristan-Wilson marked this pull request as draft June 9, 2023 18:24
@cla-bot cla-bot bot added the s label Jul 31, 2023
@Tristan-Wilson Tristan-Wilson marked this pull request as ready for review August 9, 2023 16:27
@Tristan-Wilson Tristan-Wilson changed the base branch from merge-v1.11.6 to master August 9, 2023 16:28
@Tristan-Wilson Tristan-Wilson dismissed tsahee’s stale review August 9, 2023 16:28

The base branch was changed.

Copy link
Contributor

@ganeshvanahalli ganeshvanahalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tristan-Wilson Tristan-Wilson merged commit d6778f2 into master Aug 9, 2023
2 checks passed
@tsahee tsahee deleted the enable-lint-ci branch November 28, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants