Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToB fixes #447

Merged
merged 11 commits into from
Sep 29, 2023
Merged

ToB fixes #447

merged 11 commits into from
Sep 29, 2023

Conversation

yahgwai
Copy link
Contributor

@yahgwai yahgwai commented Sep 22, 2023

Misc fixes related to tob audit

  • Rename etype to level in some errors
  • Removed unused state hashes
  • Added additional sanity check to create assertion
  • Added additional params to rollup creator salt
  • Updated upgradeSurroundingContracts comments
  • Additional tests for hash types and createlayerzeroedge conditions

@DZGoldman DZGoldman self-requested a review September 28, 2023 17:17
Copy link
Contributor

@DZGoldman DZGoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added code comments as separate PR for ease of review / editing (+ one question above, otherwise lgtm)
#457

@DZGoldman DZGoldman self-requested a review September 28, 2023 17:28
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #447 (3328877) into main (6c6f257) will decrease coverage by 2.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
- Coverage   67.84%   65.63%   -2.22%     
==========================================
  Files          41       41              
  Lines        5555     5555              
==========================================
- Hits         3769     3646     -123     
- Misses       1737     1860     +123     
  Partials       49       49              

@rauljordan rauljordan merged commit 36d1d8b into main Sep 29, 2023
7 checks passed
@rauljordan rauljordan deleted the tob-fixes branch September 29, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants