-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement --tmp
and --dev
for wallet
#135
Conversation
Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
Signed-off-by: muraca <mmuraca247@gmail.com>
@JoshOrndorff I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great work. A couple little comments, but I trust you to address them (or not) as you see fit. Merge when ready.
-
I was thinking that Alice was the default/development key and SHAWN was only used in one or two places. Can you just double check that you got the right one.
-
What are the differences in the way the docs are rendered now? Ideally that would go in a separate PR. For example, in case there is some little bug in
--dev
and we want to revert it. We would not want to also revert the doc changes. But not a big deal in this case. -
Looks like we upped the sleep time from 10s to 20s in the CI. Was 10 not long enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed something.
When we specify --tmp
we need to generate a new random path and use it for the run, and clean it up at the end. The current PR does not generate a new random path. It just relies on the existing methods to choose the path.
This is dangerous because someone could have a "real" wallet that they hold real funds in. And they don't want to be purging all of it's data. They may also do some development work and want to use --tmp
for the dev work. We would not want this person to simply add --tmp
to the cli and accidentally purge their real data.
If you really like the existing semantics, I think a better flag name would be --purge-when-done
or similar. But I like the idea to generate a random path better because that's exactly what Substrate does.
Looks like Alice is never used in the wallet, Shawn is the default development key and it is also used in the template runtime.
New lines are respected, allowing some longer descriptions to be displayed correctly.
It was barely enough to kickstart the node, but not to produce any blocks. I should mention it in the changelog in the PR description as well.
I agree. I'll proceed with that. |
Signed-off-by: muraca <mmuraca247@gmail.com>
Line 23 in 20efeb5
Is this comment still relevant? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You’re right. That comment is outdated and should be removed.
Signed-off-by: muraca <mmuraca247@gmail.com>
0511a91
to
37e842d
Compare
closes #133
--dev
arg is set--tmp
will clear the data folder at the end.--dev
enables--tmp
under the hood.I also improved some documentation here and there, mostly added
verbatim_doc_comment
to show the entire doc comment and support newlines.