Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing ppa arguments into the image build as well #38

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vorlonofportland
Copy link

There are occasions when you want to support specifying a ppa to configure in the target image, not just in the build chroot. This is a first pass at implementing this.

In Launchpad itself, these two concepts are kept separate. The one is specified in terms of the archive that the image is built "in"; the other is EXTRA_PPAS that are passed into the buildlivefs command. So by trying to use the single --ppa option for both we are conflating a bit. Do we care?

Further limitations:

  • If the ppa is a private ppa, do not pass it into the build. This isn't supported by launchpad-buildd today.
  • You may want more than one ppa. For instance, we have some custom images that use one (private) ppa for the source of the build scripts, but want to configure a separate (public) in the target image. I haven't implemented this yet as part of this branch, because it takes some thinking how we want to match up when we have a mix of --ppa and --ppa-key options on the commandline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant