Remove instance name from K8s Job file paths #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #66137: Explore using NFS server for shared storage with tentacle + jobs. |
Base automatically changed from
ap/generate-machine-key-in-home-directory-k8s
to
main
November 30, 2023 04:12
APErebus
force-pushed
the
ap/tweak-k8s-code
branch
from
dce6add to
e9bc984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
When running in K8s, we don't actually have an instance name in the home directory (as there is only one instance). The existing job code assumed there would be an instance name under the home directory
Results
Removes the instance name from relevant paths
Shortcut story: [sc-66137]
How to review this PR
Quality ✔️
Pre-requisites