Generate machine key in home directory in K8s #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APErebus
commented
Nov 30, 2023
| @@ -14,8 +14,7 @@ public static class Kubernetes | |||
| /// <summary> | |||
| /// Indicates if the Tentacle is running inside a Kubernetes cluster. | |||
| /// </summary> | |||
| public static bool IsRunningInKubernetes => !string.IsNullOrWhiteSpace(Environment.GetEnvironmentVariable("KUBERNETES_SERVICE_HOST")) || | |||
| (bool.TryParse(Environment.GetEnvironmentVariable("OCTOPUS__TENTACLE__FORCEK8S"), out var b) && b); | |||
| public static bool IsRunningInKubernetes => bool.TryParse(Environment.GetEnvironmentVariable("OCTOPUS__K8STENTACLE__FORCE"), out var b) && b; | |||
There was a problem hiding this comment.
Changed this to be explicit and this env var will be set in the helm/pod configuration
APErebus
force-pushed
the
ap/generate-machine-key-in-home-directory-k8s
branch
from
891bc33 to
5e10c1f
Compare
|
This pull request has been linked to Shortcut Story #66137: Explore using NFS server for shared storage with tentacle + jobs. |
zentron
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The machine key is currently generated for linux in
/etc/octopus/machinekey. This then is regenerated when the pod restarts, so the encrypted values (which are stored in the home directory, on a NFS share) can't be decryptedResults
When running in K8S only, we change the location of the file to generate the machine key to be in the configured environment variable
TentacleHome(which currently is the NFS share/octopus). This results in the key being persisted across pod restarts and the cert can be decryptedShortcut story: [sc-66137]
How to review this PR
Quality ✔️
Pre-requisites