Enable Halibut TCP Keepalives by default #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #64824: Rollout TCP Keep Alives for Tentacle. |
nathanwoctopusdeploy
force-pushed
the
sast/enable-halibut-tcp-keep-alives-by-default
branch
from
3770d23 to
a453f64
Compare
LukeButters
reviewed
Nov 30, 2023
| var builder = new ContainerBuilder(); | ||
| var configuration = new StubTentacleConfiguration(); | ||
| configuration.TentacleCertificate = configuration.GenerateNewCertificate(); | ||
| configuration.AddOrUpdateTrustedOctopusServer(new OctopusServerConfiguration("NOPE")); |
LukeButters
approved these changes
Nov 30, 2023
nathanwoctopusdeploy
deleted the
sast/enable-halibut-tcp-keep-alives-by-default
branch
nathanwoctopusdeploy
added a commit
that referenced
this pull request
Dec 1, 2023
This reverts commit ac4a784.
nathanwoctopusdeploy
added a commit
that referenced
this pull request
Dec 1, 2023
nathanwoctopusdeploy
added a commit
that referenced
this pull request
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Enable Halibut TCP Keepalives by default
The environment variable has been left so that TCP keep alive can be disabled if required.
[sc-64824]
Related to #692
How to review this PR
Quality ✔️
Pre-requisites