Attempt to download tentacles multiple times #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeButters
commented
Nov 29, 2023
| } | ||
| } | ||
| } | ||
| catch (Exception e) | ||
| { | ||
| throw new Exception($"Failure to download: {downloadUrl}. After {totalTime.Elapsed.TotalSeconds} seconds we only downloaded, {totalRead}", e); |
There was a problem hiding this comment.
These logs don't make it to the build server :(, so instead make the exception contain information already in the logs.
LukeButters
force-pushed
the
sast/improve-tentacle-compat-downloading
branch
from
5778485 to
ad95f8f
Compare
LukeButters
commented
Nov 30, 2023
| @@ -17,56 +18,99 @@ public class OctopusPackageDownloader | |||
| { | |||
| public static async Task DownloadPackage(string downloadUrl, string filePath, ILogger logger) | |||
| { | |||
| var exceptions = new List<Exception>(); | |||
| for (int i = 0; i < 5; i++) | |||
There was a problem hiding this comment.
Simple for loop is simple
nathanwoctopusdeploy
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We are seeing time outs when downloading older tentacle versions, where the timeout is set to 150s.
This PR attempts to help with that by:
How to review this PR
Quality ✔️
Pre-requisites