-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use laminas code 4.x branch #639
Closed
martinssipenko
wants to merge
11
commits into
Ocramius:2.11.x
from
martinssipenko:laminas-code-4-php8
Closed
Use laminas code 4.x branch #639
martinssipenko
wants to merge
11
commits into
Ocramius:2.11.x
from
martinssipenko:laminas-code-4-php8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent enough version is needed for compatiblity with PHP 8
That version is compatible with PHP 8
We need one that has support for PHP 8, so let's pick the latest.
Version 3 has a requirement on webmozart/glob, which is not yet compatible with PHP 8
Many libs might be compatible although they do not advertise it, using that flag will allow us to see if tests pass and to add more tests in the meantime.
3.5.0 is compatible with PHP 8
It should be the easiest one.
* 2.11.x: update lstrojny/functional-php Update PHPUnit only revert lock file indent Upgrade to PHPunit ^9.4 Remove usage of deprecated method Various minor cleanups
Closing here: will use #637 and merge it locally myself :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.