Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - #208 document new ghost object behavior #281

Merged
merged 26 commits into from
Jan 23, 2016

Conversation

Ocramius
Copy link
Owner

Provides docs for #208

@Ocramius Ocramius added the docs label Jan 22, 2016
@Ocramius Ocramius self-assigned this Jan 22, 2016
@Ocramius Ocramius added this to the 2.0.0 milestone Jan 22, 2016
@fntlnz
Copy link

fntlnz commented Jan 23, 2016

Form is OK, the only thing that's unclear to me is that if in the end there's any way to not skip the constructor.

@Ocramius
Copy link
Owner Author

@fntlnz you can actually call the constructor, if you want, but since we're setting all the state, is that an actual use-case?

@Ocramius
Copy link
Owner Author

@fntlnz added block to clarify that :-)

@fntlnz
Copy link

fntlnz commented Jan 23, 2016

@Ocramius at the moment I don't see any use case for that. But probably because is stated "the constructor is not called" one may think something like: "hey I have to proxy that old legacy painful object with a lot of business logic poured into the controller and I want to actually call it to be sure that the things are going as before but here's it's written that the controller isn't called. Unfortunately I can't use this tool :( ". That's quite a edge case and son of poorly designed code of course but, shit happens.
Thanks for clarifying that :)

@Ocramius
Copy link
Owner Author

@fntlnz thanks for bringing it up :-)

Ocramius added a commit that referenced this pull request Jan 23, 2016
…-behavior

Docs - #208 document new ghost object behavior
@Ocramius Ocramius merged commit 252c006 into master Jan 23, 2016
@Ocramius Ocramius deleted the docs/#208-document-ghost-object-behavior branch January 23, 2016 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants