Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to a minimum of composer-runtime-api:^2.1 as soon as it is available, drop composer/composer:<2.0.14 conflict #702

Closed
Ocramius opened this issue May 25, 2021 · 2 comments · Fixed by #709
Closed

Bump to a minimum of composer-runtime-api:^2.1 as soon as it is available, drop composer/composer:<2.0.14 conflict #702

Ocramius opened this issue May 25, 2021 · 2 comments · Fixed by #709
Assignees
@Ocramius
Labels
enhancement
Milestone
2.13.0

Comments

@Ocramius
Copy link
Owner

See #700

Mostly cleanup work.
Ocramius added a commit to derrabus/ProxyManager that referenced this issue May 25, 2021
@Ocramius
Dropped compatibility with composer/composer:<2.0.14
b5ee473 
As discussed in Ocramius#700
As noted in Ocramius#700 (comment)

Since `composer/composer` broke BC in 2.0.14 by adding a runtime side-effect to a
functionally pure API (`InstalledVersions::getRawData()`) it is safest to move away
from it.

Since `composer-runtime-api:2.1.0` is not yet available, the safest approach is to
introduce a conflict with `composer/composer:<2.0.14` for now.

In the next release, we'll drop this `conflict` block and add bump `composer-runtime-api`
instead ( Ocramius#702 ).
@Ocramius Ocramius added this to the 2.13.0 milestone May 25, 2021
@Ocramius Ocramius mentioned this issue May 25, 2021
Merged
Ainschy added a commit to Ainschy/conflicts that referenced this issue May 25, 2021
@Ainschy
Update fail by Ocramius/proxy-manager in 2.12.0
9ce0b5c 
see Ocramius/ProxyManager#702 it's a problem when composer < 2.0.14
@Ainschy Ainschy mentioned this issue May 25, 2021
Merged
leofeyer pushed a commit to contao/conflicts that referenced this issue May 25, 2021
@Ainschy
Update fail by Ocramius/proxy-manager in 2.12.0 (#26)
1b5cc17 
see Ocramius/ProxyManager#702 it's a problem when composer < 2.0.14
@Seldaek
Copy link

Seldaek commented Jun 9, 2021

2.1 is available now btw :)

@Ocramius
Copy link
Owner Author

Ocramius commented Jun 9, 2021

Excellent: on it :-)

@Ocramius Ocramius self-assigned this Jun 9, 2021
Ocramius added a commit that referenced this issue Jun 9, 2021
@Ocramius
Upgraded to composer-runtime-api:^2.1.0
e3c1d44 
`composer-runtime-api:2.0.x` included deprecations that caused crashes/errors before
`composer/composer:2.0.14`, and a restriction to `"conflict": {"composer/composer": "<2.0.14"}`
did not work ( #700 (comment) ).

In order to clean this up, this fixes #702 by declaring a the dependency to `composer-runtime-api:^2.1.0`
explicitly, effectively excluding `composer/composer:~2.0.0` from installation candiates.
@Ocramius Ocramius mentioned this issue Jun 9, 2021
Merged
Ocramius added a commit that referenced this issue Jun 9, 2021
@Ocramius
Upgraded to composer-runtime-api:^2.1.0
8324608 
`composer-runtime-api:2.0.x` included deprecations that caused crashes/errors before
`composer/composer:2.0.14`, and a restriction to `"conflict": {"composer/composer": "<2.0.14"}`
did not work ( #700 (comment) ).

In order to clean this up, this fixes #702 by declaring a the dependency to `composer-runtime-api:^2.1.0`
explicitly, effectively excluding `composer/composer:~2.0.0` from installation candiates.
Ocramius added a commit that referenced this issue Jun 9, 2021
@Ocramius
Merge pull request #709 from Ocramius/feature/#702-bump-composer-runt…
21e2b4a 
…ime-api

Upgraded to `composer-runtime-api:^2.1.0`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
2.13.0
Development

Successfully merging a pull request may close this issue.

Upgraded to composer-runtime-api:^2.1.0 Ocramius/ProxyManager
2 participants
@Ocramius @Seldaek