Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate semicolons generated #264

Closed
holtkamp opened this issue Dec 30, 2015 · 1 comment
Closed

Duplicate semicolons generated #264

holtkamp opened this issue Dec 30, 2015 · 1 comment
Assignees
@Ocramius
Labels
enhancement
Milestone
2.0.0

Comments

@holtkamp
Copy link

When looking at some generated code when used in combination with PHP-DI, the proxy classes contain snippets like:

            return isset($targetObject->$name);;
            return;
            unset($targetObject->$name);;
            return;

Note the duplicate semicolons, which seems to be caused by this line
@Ocramius Ocramius self-assigned this Dec 30, 2015
@Ocramius Ocramius added this to the 2.0.0 milestone Dec 30, 2015
Ocramius added a commit that referenced this issue Dec 30, 2015
@Ocramius
#264 - duplicate semicolon removal
dbf4b43
@Ocramius Ocramius mentioned this issue Dec 30, 2015
Merged
Ocramius added a commit that referenced this issue Dec 30, 2015
@Ocramius
Merge pull request #267 from Ocramius/hotfix/#264-duplicate-semicolon…
1c6f0c4 
…-removal

#264 - duplicate semicolon removal
@Ocramius
Copy link
Owner

@holtkamp fixed, thanks!

Ocramius added a commit that referenced this issue Dec 30, 2015
@Ocramius
#264 - correcting links in the footer of the docs
dea26ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@Ocramius @holtkamp