Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop PHP 5.4 support #167

Closed
Ocramius opened this issue Jun 20, 2014 · 4 comments · Fixed by #711
Closed

Drop PHP 5.4 support #167

Ocramius opened this issue Jun 20, 2014 · 4 comments · Fixed by #711
Assignees
@Ocramius
Labels
BC break enhancement
Milestone
2.0.0

Comments

@Ocramius
Copy link
Owner

No description provided.

@Ocramius Ocramius added this to the 1.0.0 milestone Jun 20, 2014
@adlawson
Copy link

May I ask what the motivation for this is?
Just curious. I assume you wouldn't drop support without reason.

@Ocramius
Copy link
Owner Author

@adlawson maybe "moving forward". I am not sure if I will do this for 1.0.0 or 2.0.0, still, people should not have problem with this, as all the future LTS distros support 5.5

@Ocramius Ocramius modified the milestones: 1.0.0, 2.0.0 Sep 16, 2014
@Ocramius Ocramius removed this from the 2.0.0 milestone Oct 7, 2014
@Ocramius Ocramius added this to the 2.0.0 milestone Dec 14, 2014
@Ocramius
Copy link
Owner Author

Decided to move this into 2.0.0. By the end of 1.0.0 support PHP 5.5 will already be EOL.

@Ocramius Ocramius self-assigned this Dec 14, 2014
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - Removing check for Closure::bind() support
8cfd315
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - s/'Closure'/Closure::class
8d31e76
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - don't skip tests depending on Closure::bind() support (assum…
5b94cf9 
…ing it as of PHP 5.4)
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - s/'Phar'/Phar::class
e901b36
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - s/'Kitchen'/Kitchen::class
efc2eeb
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - ::class over string reference
1042929
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - ::class over string reference in factory tests
4509fa2
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - ::class over string reference in factory tests
58a8df1
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - ::class over string reference in generator tests
2b271b8
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - don't skip tests depending on Closure::bind() support (assum…
1cfc752 
…ing it as of PHP 5.4)
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - don't skip tests depending on `ReflectionParameter::isCallable…
1c84770 
…()` support (assuming it as of PHP 5.4)
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - ::class over string reference in method generator tests
6353bf1
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - ::class over string reference in proxy class generators
87631bb
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - ::class over string reference in method generator
43fccd4
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - ::class over string reference in property generator
51f698a
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - ::class over string reference in configuration test
4f4ed23
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - ::class over string reference in autoloader test
2d2fa42
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - ::class over string reference in AbstractBaseFactory test
f024422
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - ::class over string references in tests (regex-based replace…
57a9aa1 
…ment)
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - Importing used classes, making dependencies explicit and refac…
f60d2d7 
…toring easier
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - Short array syntax usage for sources
51b9b3c
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - Short array syntax usage in generated code
23ad060
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - Short array syntax usage in tests
eadfe7e
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - Short array syntax usage in examples
e1ac061
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - Short array syntax usage in docs
7d9b361
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - Short array syntax usage in html docs
1697853
@Ocramius Ocramius mentioned this issue Dec 14, 2014
Merged
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - Remove code specifically designed to skip tests in PHP <= 5.4.1
ade7b1f
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - Remove code specifically designed to skip tests in PHP <= 5.4.1
f0a57e2
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - Remove code specifically designed to skip tests in PHP <= 5.4.1
92e44f3
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - Remove code specifically designed to skip tests in PHP <= 5.4.1
5ab72df
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - Remove code specifically designed to skip tests in PHP <= 5.4.1
2e0500a
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - Remove code specifically designed to skip tests in PHP <= 5.4.1
8f76278
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - Remove code specifically designed to skip tests in PHP <= 5.4.1
9ff9a88
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - Remove code specifically designed to skip tests in PHP <= 5.4.1
bdd7298
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - Remove code specifically designed to skip tests in PHP < 5.4
41a3cad
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - Bumping to php_codesniffer ~2.0
0726bc1
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - Skipping CS checks until further decision
b3ec382
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
#167 - Optimized imports
31c16fa
Ocramius added a commit that referenced this issue Dec 14, 2014
@Ocramius
Merge pull request #204 from Ocramius/cleanup/#167-remove-php-5-4-sup…
841fe0e 
…port

Cleanup: #167 - remove PHP 5.4 support
@Ocramius
Copy link
Owner Author

Handled in #204

@Ocramius Ocramius mentioned this issue Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ocramius Ocramius

Labels
BC break enhancement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Dependency upgrades and general cleanup Ocramius/ProxyManager
2 participants
@Ocramius @adlawson