Skip to content
This repository has been archived by the owner on Jul 12, 2019. It is now read-only.

Consider making instantiator private caches static #4

Closed
Ocramius opened this issue Jun 14, 2014 · 2 comments
Closed

Consider making instantiator private caches static #4

Ocramius opened this issue Jun 14, 2014 · 2 comments
Assignees
@Ocramius
Labels
enhancement
Milestone
1.0.0

Comments

@Ocramius
Copy link
Owner

The Instantiator default implementation does not need a per-instance cache.
The caches may just be static instead.
@Ocramius Ocramius added this to the 1.0.0 milestone Jun 14, 2014
@Ocramius Ocramius self-assigned this Jun 14, 2014
@Ocramius
Copy link
Owner Author

Note that this will also render the "warmed up cache" performance tests useless

Ocramius added a commit that referenced this issue Jun 15, 2014
@Ocramius
#4 - Making cached instantiators/cloneables logic cacheable
6f0551e
Ocramius added a commit that referenced this issue Jun 15, 2014
@Ocramius
#4 - testing for warmup or not is now useless due to the static cache…
29d12d5 
… in the instantiator
Ocramius added a commit that referenced this issue Jun 15, 2014
@Ocramius
#4 - removing references to class warmup
85911c8
@Ocramius Ocramius mentioned this issue Jun 15, 2014
Merged
Ocramius added a commit that referenced this issue Jun 15, 2014
@Ocramius
#4 - splitting instantiation of the lazy maps into own methods
4bf0f60
Ocramius added a commit that referenced this issue Jun 15, 2014
@Ocramius
Merge pull request #5 from Ocramius/feature/#4-static-cached-instance…
7e9bbf6 
…s-map

#4 - static cached instances map
@Ocramius
Copy link
Owner Author

Handled in #5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@Ocramius