Add PHP 8.4 compatibility #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdecool
force-pushed
the
php-84
branch
3 times, most recently
from
c0f7470 to
5d9bb61
Compare
|
This MR requires Roave/infection-static-analysis-plugin#497 to have the CI green. |
|
Upstream has a PHP 8.4 support now |
Ocramius
added
enhancement
dependencies
|
Poke me when dependencies are updated, and it shall be shipped :) We may need to drop PHP 8.1 |
|
ping @Ocramius ✅ |
Ocramius
approved these changes
Jan 28, 2025
| @@ -19,12 +19,17 @@ class MissingBatchItemException extends UnexpectedValueException implements Exce | |||
| { | |||
| public static function fromInvalidReference(ClassMetadata $metadata, object $object): MissingBatchItemException | |||
| { | |||
| $identifier = json_encode($metadata->getIdentifierValues($object)); | |||
There was a problem hiding this comment.
Not a problem here, but JSON_THROW_ON_ERROR in future: let it crash and burn ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #399