fix(webapp): update embeds.vue #7953
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I add a margin in between the 2 buttons.
Tirokk
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Thanks for your contribution @Dibyajyoti1515 !
I have some questions. 🤗
PS: Please run yarn lint --fix in the webapp folder.
| @@ -17,7 +17,7 @@ | |||
| <ds-text> | |||
| {{ $t('settings.embeds.status.change.question') }} | |||
| </ds-text> | |||
| <base-button @click="submit" :filled="!disabled" :disabled="!disabled"> | |||
| <base-button @click="submit" :filled="!disabled" :disabled="!disabled" style="margin-right: 5px;"> | |||
There was a problem hiding this comment.
This is a great idea!
Would love to have this via a class rather than by a style attribute, because CSS classes are recommended in such cases.
Or as ds-space element like done in other places which is standardized.
The issue pointed to the space between the buttons to the text underneath which appears to small.
This should be solved as well by an CSS class, if you agree.
Or as ds-space element like done in other places which is standardized.
| @@ -54,6 +54,7 @@ export default { | |||
| data() { | |||
| return { | |||
| disabled: null, | |||
| print: true, | |||
There was a problem hiding this comment.
Why you add this and never use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add a margin in between the 2 buttons.
🍰 Pullrequest
Issues
Todo