Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🍰 Add Group To User Teaser, On Post Page, And On News Feed Etc. #5502

Merged
merged 15 commits into from
Oct 22, 2022
Merged

feat: 🍰 Add Group To User Teaser, On Post Page, And On News Feed Etc. #5502

merged 15 commits into from
Oct 22, 2022

Conversation

Tirokk
Copy link
Member

@Tirokk Tirokk commented Oct 17, 2022

🍰 Pull Request

Add group link to user teaser on posts in webapp.

Issues

fixes #5501
relates #5059

Todo

  • none

@Tirokk Tirokk changed the title Add group to user teaser, on post page, and on news feed feat: 🍰 Add Group To User Teaser, On Post Page, And On News Feed Oct 17, 2022
@Tirokk Tirokk self-assigned this Oct 17, 2022
@Tirokk Tirokk added this to the 🏃 The Sprint after that... milestone Oct 17, 2022
@Tirokk Tirokk mentioned this pull request Oct 17, 2022
Closed
Mogge
Mogge previously requested changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@Mogge Mogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

  • On the user profile, the group is not shown on the post teaser
  • In the group profile, the group is not shown on the post teaser

Is this on purpose?

@Tirokk Tirokk changed the title feat: 🍰 Add Group To User Teaser, On Post Page, And On News Feed feat: 🍰 Add Group To User Teaser, On Post Page, And On News Feed Etc. Oct 19, 2022
@Tirokk Tirokk requested a review from Mogge October 19, 2022 17:03
@Tirokk
Copy link
Member Author

Tirokk commented Oct 19, 2022

Code looks good to me.

* On the user profile, the group is not shown on the post teaser

* In the group profile, the group is not shown on the post teaser

Is this on purpose?

This was not on porpose and I have solved this. @Mogge

Tirokk added 2 commits October 19, 2022 19:15
@Tirokk
Merge branch '5059-groups/5385-webapp-post-in-group' of github.com:Oc…
d223826 
…elot-Social-Community/Ocelot-Social into 5059-groups/5501-add-group-link-to-posts-in-webapp
@Tirokk
Lower webapp coverage from 65% to 64%
1c3a592
ulfgebhardt
ulfgebhardt requested changes Oct 20, 2022
View reviewed changes
Copy link
Member

@ulfgebhardt ulfgebhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the group profile there is still an @ in the profile
image

ulfgebhardt
ulfgebhardt previously requested changes Oct 20, 2022
View reviewed changes
Copy link
Member

@ulfgebhardt ulfgebhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

There should be an in between user and the group
@jenny-rostock Jenny Rostock in &school-for-citizens School For Citizens

Base automatically changed from 5059-groups/5385-webapp-post-in-group to 5059-epic-groups October 20, 2022 11:19
@Tirokk Tirokk dismissed stale reviews from Mogge and ulfgebhardt October 21, 2022 09:38

done

@Tirokk Tirokk merged commit 2e50e61 into 5059-epic-groups Oct 22, 2022
@Tirokk Tirokk deleted the 5059-groups/5501-add-group-link-to-posts-in-webapp branch October 22, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulfgebhardt ulfgebhardt ulfgebhardt approved these changes

@ogerly ogerly Awaiting requested review from ogerly

@Mogge Mogge Awaiting requested review from Mogge

Assignees

@Tirokk Tirokk

Labels
design project: yunite service: webapp
Projects
None yet
Milestone
🏃 22/10 Oktober
Development

Successfully merging this pull request may close these issues.
3 participants
@Tirokk @ulfgebhardt @Mogge