Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🍰 Implement Group GQL Model And CRUD Resolvers – First Step #5139

Merged
merged 33 commits into from
Aug 15, 2022
Merged

feat: 🍰 Implement Group GQL Model And CRUD Resolvers – First Step #5139

merged 33 commits into from
Aug 15, 2022

Conversation

Tirokk
Copy link
Member

@Tirokk Tirokk commented Aug 2, 2022 •
edited
Loading

🍰 Pullrequest

Implement group GQL model and CRUD resolvers – first step.

Issues

Todo

  • @Mogge suggestions:
    • international → global
    • remove wasSeede
  • GraphQL
  • resolvers:
    • CreateGroup:
      • test correct slugification
    • check for tests in:
      • backend/src/middleware/permissionsMiddleware.spec.js
      • backend/src/middleware/slugifyMiddleware.spec.js
  • seeding:
    • seed a group
  • Neo4j database:
    • how to add a slug contraint for Group label?
      • where is the slug contraint for Post and User label? See backend/src/db/migrate/store.js
  • cleanup: search for Wolle

@Tirokk Tirokk self-assigned this Aug 2, 2022
@Tirokk Tirokk marked this pull request as draft August 2, 2022 10:31
Tirokk added 17 commits August 2, 2022 16:20
@Tirokk
Implement 'CreateGroup' with tests
f565e5f
@Tirokk
Fix Group name slugification
4f16465
@Tirokk
Add migration with fulltext indeces and unique keys for groups
da2c7dc
@Tirokk
Test groups creation in slugifyMiddleware
fc20143
@Tirokk
Rename 'UserGroup' to 'UserRole'
ea0223b
@Tirokk
Fix linting
2c402ba
@Tirokk
Add comment about faking the 'gql' tag in the backend
45558f0
@Tirokk
Implement 'description', 'groupType', and 'actionRadius' in 'CreateGr…
520598c 
…oup'
@Tirokk
Refactor relations ':OWNS' and ':ADMINISTERS' to ':MEMBER_OF' with pr…
cc44ee8 
…operties
@Tirokk
Implement 'Group' query, first step
9441164
@Tirokk
Implement 'Group' query, second step
867b78d
@Tirokk
Merge branch 'master' of github.com:Ocelot-Social-Community/Ocelot-So…
2107dd4 
…cial into 5059-groups/5131-implement-group-gql-model-and-crud

# Conflicts:
#	backend/.env.template
#	webapp/.env.template
@Tirokk
Implement 'Group' query, next step
fcca0f3
@Tirokk
Merge branch '5059-epic-groups' of github.com:Ocelot-Social-Community…
504a9bc 
…/Ocelot-Social into 5059-groups/5131-implement-group-gql-model-and-crud
@Tirokk
Add issue to TODO comment
b120565
@Tirokk
Return 'categories' in the 'Group' GQL query
7847d69
@Tirokk
Implement errors for to less or to many categories and test it
61344fc
Elweyn
Elweyn reviewed Aug 9, 2022
View reviewed changes
Copy link
Member

@Elweyn Elweyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read it and the road seems good!

Tirokk added 2 commits August 9, 2022 14:50
@Tirokk
Merge branch 'master' of github.com:Ocelot-Social-Community/Ocelot-So…
b5678f7 
…cial into 5059-groups/5131-implement-group-gql-model-and-crud

# Conflicts:
#	backend/src/schema/types/type/User.gql
@Tirokk
Implement error for to short 'description' and test it
117bd5e
@Tirokk Tirokk changed the title feat: [WIP] 🍰 Implement Group GQL Model And CRUD Resolvers feat: [WIP] 🍰 Implement Group GQL Model And CRUD Resolvers – First Step Aug 9, 2022
Tirokk added 2 commits August 9, 2022 16:37
@Tirokk
Merge branch '5059-epic-groups' of github.com:Ocelot-Social-Community…
78eeb7e 
…/Ocelot-Social into 5059-groups/5131-implement-group-gql-model-and-crud
@Tirokk
Cleanup
0149af1
@Tirokk Tirokk changed the title feat: [WIP] 🍰 Implement Group GQL Model And CRUD Resolvers – First Step feat: 🍰 Implement Group GQL Model And CRUD Resolvers – First Step Aug 9, 2022
@Tirokk Tirokk requested review from Elweyn and Mogge August 9, 2022 14:58
@Tirokk Tirokk marked this pull request as ready for review August 9, 2022 14:58
@Tirokk
Copy link
Member Author

Tirokk commented Aug 9, 2022

After @Mogge suggestion I do the remainders in the next PR 🍀🙏🏼

Mogge
Mogge requested changes Aug 10, 2022
View reviewed changes
backend/src/schema/resolvers/groups.js Outdated Show resolved Hide resolved
backend/src/schema/resolvers/groups.js Outdated Show resolved Hide resolved
backend/src/schema/resolvers/groups.spec.js Outdated Show resolved Hide resolved
backend/src/schema/resolvers/groups.spec.js Outdated Show resolved Hide resolved
backend/src/schema/resolvers/groups.spec.js Outdated Show resolved Hide resolved
backend/src/schema/resolvers/groups.spec.js Outdated Show resolved Hide resolved
backend/src/schema/resolvers/groups.js Outdated Show resolved Hide resolved
backend/src/schema/resolvers/groups.js Outdated Show resolved Hide resolved
backend/src/schema/resolvers/groups.js Outdated Show resolved Hide resolved
backend/src/schema/types/enum/GroupActionRadius.gql Outdated Show resolved Hide resolved
Tirokk and others added 3 commits August 10, 2022 12:52
@Tirokk @Mogge
Update backend/src/schema/resolvers/groups.js
82401b1 
Co-authored-by: Moriz Wahl <moriz.wahl@gmx.de>
@Tirokk @Mogge
Update backend/src/schema/resolvers/groups.js
f150ea3 
Co-authored-by: Moriz Wahl <moriz.wahl@gmx.de>
@Tirokk
Overtake Moriz suggestions
5e741ea
@Tirokk Tirokk requested a review from Mogge August 10, 2022 11:16
@Tirokk Tirokk mentioned this pull request Aug 15, 2022
Open
3 tasks
@Tirokk Tirokk merged commit 032cf7c into 5059-epic-groups Aug 15, 2022
@Tirokk Tirokk deleted the 5059-groups/5131-implement-group-gql-model-and-crud branch August 15, 2022 11:35
@ulfgebhardt ulfgebhardt added this to the 🏃 22/10 Oktober milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mogge Mogge Mogge approved these changes

@Elweyn Elweyn Awaiting requested review from Elweyn

Assignees

@Tirokk Tirokk

Labels
project: yunite service: backend
Projects
None yet
Milestone
🏃 22/10 Oktober
Development

Successfully merging this pull request may close these issues.
4 participants
@Tirokk @Mogge @Elweyn @ulfgebhardt