Skip to content

Commit

Permalink
Merge pull request #110 from OceanBioME/jsw/update-dependencies
Browse files Browse the repository at this point in the history
Update Oceananigans/KernelAbstractions versions
  • Loading branch information
jagoosw authored Jun 24, 2023
2 parents d6c6132 + 2207525 commit f83a4df
Show file tree
Hide file tree
Showing 23 changed files with 345 additions and 838 deletions.
273 changes: 163 additions & 110 deletions Manifest.toml

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "OceanBioME"
uuid = "a49af516-9db8-4be4-be45-1dad61c5a376"
authors = ["Jago Strong-Wright <js2430@damtp.cam.ac.uk>", "John R Taylor <j.r.taylor@damtp.cam.ac.uk>", "Si Chen <sc2350@damtp.cam.ac.uk>"]
version = "0.1.2"
version = "0.2.0"

[deps]
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
Expand All @@ -16,8 +16,8 @@ StructArrays = "09ab397b-f2b6-538f-b94a-2f83cf4a842a"
Adapt = "^3.4"
DiffEqBase = "^6.100"
JLD2 = "^0.4.31"
KernelAbstractions = "^0.8.6"
Oceananigans = "^0.81.0"
KernelAbstractions = "^0.9.0"
Oceananigans = "^0.83.0"
Roots = "^2.0.0"
StructArrays = "^0.6.15"
julia = "^1.8.0"
Expand Down
2 changes: 1 addition & 1 deletion docs/Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
[compat]
CairoMakie = "0.10"
Literate = "≥2.9.0"
Oceananigans = "^0.81.0"
Oceananigans = "^0.83.0"
2 changes: 1 addition & 1 deletion docs/display_parameters.jl
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ function parameter_table(labels, values)
return output
end

function show_parameters(model; exclude = (:advection_schemes, :optionals, :light_attenuation_model, :particles, :sediment_model, # usually bgc models
function show_parameters(model; exclude = (:optionals, :light_attenuation_model, :particles, :sediment_model, # usually bgc models
:architecture, :x, :y, :z, :A, :N, :C, :nitrate_uptake, :ammonia_uptake,
:primary_production, :frond_exudation, :nitrogen_erosion, :carbon_erosion, :scalefactor, :custom_dynamics,
:pescribed_temperature, :pescribed_salinity, # usually particles
Expand Down
4 changes: 2 additions & 2 deletions docs/src/model_components/individuals/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@ You then need to overload particular functions to integrate the growth, so they

```@example particles
import Oceananigans.Biogeochemistry: update_tendencies!
import Oceananigans.LagrangianParticleTracking: update_particle_properties!, _advect_particles!
import Oceananigans.Models.LagrangianParticleTracking: update_lagrangian_particle_properties!, _advect_particles!
```

First, to integrate the particles properties we overload `update_particle_properties`, in this fictitious case we will have a Mondo-quota nutrient uptake and growth:

```@example particles
using Oceananigans.Fields: interpolate
function update_particle_properties!(particles::GrowingParticles, model, bgc, Δt)
function update_lagrangian_particle_properties!(particles::GrowingParticles, model, bgc, Δt)
@inbounds for p in 1:length(particles)
nutrients = @inbounds interpolate(model.tracers.NO₃, particle.x[p], particle.y[p], particle.z[p])
Expand Down
154 changes: 0 additions & 154 deletions examples/NPZD.jl

This file was deleted.

Loading

12 comments on commit f83a4df

@jagoosw
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/86196

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.2.0 -m "<description of version>" f83a4dfe2cd396a48dfd6bc543e8b8984eb49228
git push origin v0.2.0

@navidcy
Copy link
Collaborator

@navidcy navidcy commented on f83a4df Jun 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jagoosw v0.2 is merged in Julia registries but tagbot struggles.
can you go at https://github.com/OceanBioME/OceanBioME.jl/settings/actions and enable this last tick (Allow GitHub Actions...)? I can't do that...
Screenshot 2023-06-24 at 10 03 59 pm

Not sure if this is the culprit, let's see.

@jagoosw
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thank you, I couldn't work out why that didn't work!

@navidcy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I don't have organizational admin rights?

@jagoosw
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realised it didn't let me change it either but now I've changed it for the organisation it might work

@navidcy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navidcy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worse case worse we can create the release manually :)
it's already merged in Julia registries so if you go to Julia and do add OceanBioME you'll get the v0.2

@jagoosw
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's working now? The error says it's being rate limited "API rate limit exceeded for installation ID 28373546" so maybe we can just try again in a few minutes

@jagoosw
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I've just been releasing manually until now

@navidcy
Copy link
Collaborator

@navidcy navidcy commented on f83a4df Jun 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I've just been releasing manually until now

I see

Maybe it's working now? The error says it's being rate limited "API rate limit exceeded for installation ID 28373546"
so maybe we can just try again in a few minutes

Yea I don't know what API rate limit is... Try again... or Manually, why not :)

@jagoosw
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Please sign in to comment.