Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tear down dependencies on loggers #389

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Tear down dependencies on loggers #389

merged 2 commits into from
Sep 15, 2023

Conversation

Jonpro03
Copy link
Member

  • Move logging into the API library
  • Give classes their own loggers instead of excessive passing of Server's logger

Happy loggers correctly identifying themselves now:
image

@github-actions github-actions bot added api Relates to Obsidian.API commands Relates to Obsidian.Commands labels Sep 14, 2023
themonarchoftime
themonarchoftime approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@themonarchoftime themonarchoftime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonpro03 Jonpro03 merged commit ad42e78 into master Sep 15, 2023
@Jonpro03 Jonpro03 deleted the feature/loggers branch September 15, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themonarchoftime themonarchoftime themonarchoftime approved these changes

@Naamloos Naamloos Naamloos approved these changes

Assignees
No one assigned
Labels
api Relates to Obsidian.API commands Relates to Obsidian.Commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jonpro03 @Naamloos @themonarchoftime