Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: use private key file flag, instead of data dir flag #3393

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

KaloyanTanev
Copy link
Contributor

Change after a comment from oisin under this PR.

category: feature
ticket: none

@KaloyanTanev KaloyanTanev self-assigned this Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.34%. Comparing base (bf16cf5) to head (99c4520).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3393      +/-   ##
==========================================
+ Coverage   57.29%   57.34%   +0.05%     
==========================================
  Files         217      217              
  Lines       32028    31977      -51     
==========================================
- Hits        18349    18336      -13     
+ Misses      11783    11749      -34     
+ Partials     1896     1892       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Dec 2, 2024
@obol-bulldozer obol-bulldozer bot merged commit 7b7bbcb into main Dec 2, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the kalo/test-peers-user-priv-key branch December 2, 2024 08:38
KaloyanTanev added a commit that referenced this pull request Dec 5, 2024
Change after a [comment from oisin under this PR](ObolNetwork/obol-docs#451 (comment)).

category: feature
ticket: none
@KaloyanTanev KaloyanTanev mentioned this pull request Dec 5, 2024
obol-bulldozer bot pushed a commit that referenced this pull request Dec 5, 2024
- Slight change in the flags regarding `test peers` command, #3393.

category: misc
ticket: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants