Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: test command UX #3370

Merged
merged 11 commits into from
Nov 12, 2024
Merged

cmd: test command UX #3370

merged 11 commits into from
Nov 12, 2024

Conversation

KaloyanTanev
Copy link
Contributor

Multiple changes to improve UX of the test command:

  1. Add charon test all that runs all 5 test commands
  2. Shorten the ENRs and MEV relays URLs hashes when outputting results
  3. Sort the targets of the tests (so that it's easier to follow consecutive re-ran tests)

Also do some refactoring of the functions.

category: feature
ticket: none

@KaloyanTanev KaloyanTanev self-assigned this Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 45.88563% with 388 lines in your changes missing coverage. Please review.

Project coverage is 57.74%. Comparing base (36ec15b) to head (c806e95).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
cmd/testpeers.go 63.91% 99 Missing and 19 partials ⚠️
cmd/testperformance.go 25.82% 101 Missing and 11 partials ⚠️
cmd/testall.go 0.00% 62 Missing ⚠️
cmd/testbeacon.go 22.80% 44 Missing ⚠️
cmd/test.go 64.61% 19 Missing and 4 partials ⚠️
cmd/testvalidator.go 29.62% 19 Missing ⚠️
cmd/testmev.go 65.38% 8 Missing and 1 partial ⚠️
cmd/cmd.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3370      +/-   ##
==========================================
- Coverage   57.78%   57.74%   -0.05%     
==========================================
  Files         216      217       +1     
  Lines       31622    31619       -3     
==========================================
- Hits        18273    18257      -16     
- Misses      11446    11480      +34     
+ Partials     1903     1882      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaloyanTanev KaloyanTanev requested a review from pinebit November 11, 2024 17:33
@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Nov 12, 2024
@obol-bulldozer obol-bulldozer bot merged commit 9b04a4e into main Nov 12, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the kalo/test-command-ux branch November 12, 2024 09:00
KaloyanTanev added a commit that referenced this pull request Nov 19, 2024
Multiple changes to improve UX of the test command:
1. Add `charon test all` that runs all 5 test commands
2. Shorten the ENRs and MEV relays URLs hashes when outputting results
3. Sort the targets of the tests (so that it's easier to follow consecutive re-ran tests)

Also do some refactoring of the functions.

category: feature
ticket: none
obol-bulldozer bot pushed a commit that referenced this pull request Nov 20, 2024
Cherry-picked commits for v1.2-rc1.

**Test command**

- Add cluster lock and definition files to test peers [#3368](#3368)
- Beacon node simulation [#3361](#3361)
- General UX [#3370](#3370)
- Create real blocks with MEV test [#3378](#3378)
- Version check on beacon tests [#3379](#3379)
- Rename test performance to test infra [#3380](#3380)
- Output file improvements [#3384](#3384)
- Custom number of validators for beacon node simulation [#3385](#3385)

**Charon exit --all**

- initial refactor [#3248](#3248)
- add --all flag [#3272](#3272)
- broadcast all exits [#3288](#3288)
- fetch all exits [#3291](#3291)
- enable exit all [#3296](#3296)
- add custom testnet flags (to enable kurtosis testing) [#3317](#3317)
- improve logging and error handling [#3347](#3347)
- increase default Obol API timeout [#3353](#3353)

**Misc**

- Log leader index [#3334](#3334)
- Add third Charon relay [#3227](#3227)
- Fix promrated network overview stats [#3234](#3234)
- Harden threshold parameter checks [#3242](#3242), [#3297](#3297)
- Dependabot to bump only patch versions for our BLS library [#3352](#3352)
- Optimize Dockerfile [#3281](#3281)

**Tests / pipelines**

- Fix flaky tests [#3309](#3309),  [#3316](#3316), [#3332](#3332)
- Disable intrange linter [#3282](#3282)
- Create automate PR for release [#3310](#3310)
- Use minor versions in pipelines [#3321](#3321)
- Fix trigger-dispatch for release [#3351](#3351) [#3381](#3381)
- Fix linter [#3307](#3307) (partially)

**Docs**

- Launchpad link broken [#3231](#3231)
- Docs typos [#3236](#3236) [#3367](#3367) [#3369](#3369)

All of the rest are tens of PRs with simple version bumps across the stack.

category: misc
ticket: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants