Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: enable gnosis hotfix automatically #3257

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

pinebit
Copy link
Contributor

@pinebit pinebit commented Sep 5, 2024

  • Added chiado network spec in addition to the existing gnosis.
  • Feature gnosis_block_hotfix is enabled automatically when gnosis | chiado network is detected.
  • When the user explicitly disables gnosis_block_hotfix feature, the app just yields warning during startup:
Feature gnosis_block_hotfix is required by gnosis/chiado, but explicitly disabled

category: feature
ticket: none
feature_flag: gnosis_block_hotfix

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 69.56522% with 7 lines in your changes missing coverage. Please review.

Project coverage is 57.71%. Comparing base (92ce181) to head (f3caa27).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
app/app.go 0.00% 6 Missing ⚠️
cmd/createcluster.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3257      +/-   ##
==========================================
+ Coverage   57.67%   57.71%   +0.03%     
==========================================
  Files         211      211              
  Lines       30372    30417      +45     
==========================================
+ Hits        17517    17555      +38     
- Misses      10971    10972       +1     
- Partials     1884     1890       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

app/featureset/config.go Outdated Show resolved Hide resolved
Co-authored-by: Kaloyan Tanev <24719519+KaloyanTanev@users.noreply.github.com>
@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Sep 10, 2024
Copy link

sonarcloud bot commented Sep 10, 2024

@obol-bulldozer obol-bulldozer bot merged commit 46a5509 into main Sep 10, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/auto-enable-gnosis-fix branch September 10, 2024 07:36
pinebit added a commit that referenced this pull request Sep 16, 2024
* Added `chiado` network spec in addition to the existing `gnosis`.
* Feature `gnosis_block_hotfix` is enabled automatically when gnosis | chiado network is detected.
* When the user explicitly disables `gnosis_block_hotfix` feature, the app just yields warning during startup:

```
Feature gnosis_block_hotfix is required by gnosis/chiado, but explicitly disabled
```

category: feature
ticket: none
feature_flag: gnosis_block_hotfix
@pinebit pinebit mentioned this pull request Sep 16, 2024
obol-bulldozer bot pushed a commit that referenced this pull request Sep 17, 2024
For release v1.1.1 cherry picked:

* [core/validatorapi: workaround for Gnosis proposals](#3238)
* [*: enable gnosis hotfix automatically](#3257)
*: [fix flaky testpeers test #3267](#3267)
* [cmd: increase testpeers tests timeouts #3268](#3268)
* [cmd: fix test peers out of range #3280](#3280)
* [testutil: update docker-compose command to docker compose](#3249)

category: misc
ticket: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants