*: add fio tests for disk performance #3203
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3203 +/- ##
==========================================
- Coverage 58.07% 57.66% -0.41%
==========================================
Files 211 211
Lines 30253 30369 +116
==========================================
- Hits 17569 17512 -57
- Misses 10789 10971 +182
+ Partials 1895 1886 -9 ☔ View full report in Codecov by Sentry. |
|
Sonarcloud code duplication does not pass, but I personally do not agree with it... |
There was a problem hiding this comment.
Left some comments, I have doubts about the test parameters.
That said, I think we should concentrate disk tests around a block size that makes sense for validator nodes, considering blobs etc.
I'd love @OisinKyne input on this.
There was a problem hiding this comment.
Left some comments, I have doubts about the test parameters.
That said, I think we should concentrate disk tests around a block size that makes sense for validator nodes, considering blobs etc.
I'd love @OisinKyne input on this.
|
KaloyanTanev
added
the
merge when ready
| @@ -47,7 +47,7 @@ func newTestCmd(cmds ...*cobra.Command) *cobra.Command { | |||
| root := &cobra.Command{ | |||
| Use: "test", | |||
| Short: "Test subcommands provide test suite to evaluate current cluster setup", | |||
| Long: `Test subcommands provide test suite to evaluate current cluster setup. Currently there is support for peer connection tests, beacon node and validator API.`, | |||
| Long: `Test subcommands provide test suite to evaluate current cluster setup. The full validator stack can be tested - charon peers, consensus layer, validator client, MEV. Current machine's performance can be examined as well.`, | |||
There was a problem hiding this comment.
| Long: `Test subcommands provide test suite to evaluate current cluster setup. The full validator stack can be tested - charon peers, consensus layer, validator client, MEV. Current machine's performance can be examined as well.`, | |
| Long: `Test subcommands provide a test suite to evaluate a proposed cluster setup. Aspects such as charon's peer connections, its consensus client, its validator client, candidate MEV relays, the node's disk, memory, and network, and more can all be tested ahead of creating a Distributed Validator.`, |
category: feature
ticket: #3207