Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: new thresholds for test command #3132

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

KaloyanTanev
Copy link
Contributor

Revise thresholds for pinging and BN peers.

category: misc
ticket: none

@KaloyanTanev KaloyanTanev self-assigned this Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 56.85%. Comparing base (360aece) to head (8d72a2c).
Report is 2 commits behind head on main.

Files Patch % Lines
cmd/testpeers.go 0.00% 0 Missing and 4 partials ⚠️
cmd/testbeacon.go 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3132      +/-   ##
==========================================
+ Coverage   56.77%   56.85%   +0.08%     
==========================================
  Files         208      208              
  Lines       29317    29314       -3     
==========================================
+ Hits        16644    16666      +22     
+ Misses      10834    10807      -27     
- Partials     1839     1841       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaloyanTanev KaloyanTanev force-pushed the kalo/revise-test-command-thresholds branch from 713d521 to 4814ea7 Compare June 11, 2024 15:55
@KaloyanTanev KaloyanTanev force-pushed the kalo/revise-test-command-thresholds branch from 4814ea7 to 8d72a2c Compare June 11, 2024 16:02
Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@KaloyanTanev KaloyanTanev requested a review from gsora June 11, 2024 16:03
@gsora gsora added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 11, 2024
@obol-bulldozer obol-bulldozer bot merged commit 148e1c7 into main Jun 11, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the kalo/revise-test-command-thresholds branch June 11, 2024 16:13
gsora pushed a commit that referenced this pull request Jun 11, 2024
Revise thresholds for pinging and BN peers.

category: misc
ticket: none
obol-bulldozer bot pushed a commit that referenced this pull request Jun 11, 2024
Continuation of PR #3132 , as this part was skipped because of cherrypicking for v1.

category: misc
ticket: none
obol-bulldozer bot pushed a commit that referenced this pull request Jun 11, 2024
- #3130
- #3131
- #3132

category: misc
ticket: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants