core/validatorapi: return requested validators #3123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3123 +/- ##
==========================================
- Coverage 56.82% 56.78% -0.04%
==========================================
Files 208 208
Lines 29276 29305 +29
==========================================
+ Hits 16637 16642 +5
- Misses 10801 10828 +27
+ Partials 1838 1835 -3 ☔ View full report in Codecov by Sentry. |
pinebit
approved these changes
Jun 6, 2024
Instead of always returning the full cache on Validators() requests, only return whatever was requested originally. Still check cache first, then upstream BN, then if anything comes up return to the caller. Harden tests to check for this behavior. Log a debug message when refreshing the validator cache. Make sure to always refresh the validator cache as soon as the first observed epoch begins, then fall back to the standard refresh pattern (once every epoch).
gsora
force-pushed
the
gsora/validator-cache-return-only-requested
branch
from
f153b3e
to
7e4a750
Compare
|
KaloyanTanev
approved these changes
Jun 6, 2024
gsora
added
the
merge when ready
obol-bulldozer
bot
deleted the
gsora/validator-cache-return-only-requested
branch
gsora
added a commit
that referenced
this pull request
Jun 6, 2024
Instead of always returning the full cache on Validators() requests, only return whatever was requested originally. Still check cache first, then upstream BN, then if anything comes up return to the caller. Harden tests to check for this behavior. Log a debug message when refreshing the validator cache. Make sure to always refresh the validator cache as soon as the first observed epoch begins, then fall back to the standard refresh pattern (once every epoch). category: bug ticket: none
obol-bulldozer bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
- #3123 category: misc ticket: none
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always returning the full cache on Validators() requests, only return whatever was requested originally.
Still check cache first, then upstream BN, then if anything comes up return to the caller.
Harden tests to check for this behavior.
Log a debug message when refreshing the validator cache.
Make sure to always refresh the validator cache as soon as the first observed epoch begins, then fall back to the standard refresh pattern (once every epoch).
category: bug
ticket: none