Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: exit UX tweak #3057

Merged
merged 3 commits into from
Apr 30, 2024
Merged

cmd: exit UX tweak #3057

merged 3 commits into from
Apr 30, 2024

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented Apr 29, 2024

Implement several UX tweaks on the charon exit subcommands:

  • Instead of printing "Fatal error: could not load keystore: no keys found", add some more context and point the user to the culprit of the issue: "Fatal error: could not load keystore, check if path exists: no keys found {"path": ".charon/validator_keys"}".
  • Add [REQUIRED] suffix to all the required CLI flags.
  • Clarified what's the purpose of fetch and broadcast.

category: misc
ticket: none

Instead of printing "Fatal error: could not load keystore: no keys found", add some more context and point the user to the culprit of the issue: "Fatal error: could not load keystore, check if path exists: no keys found {"path": ".charon/validator_keys"}".
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 54.62%. Comparing base (fff580a) to head (53d928f).
Report is 1 commits behind head on main.

Files Patch % Lines
cmd/exit.go 0.00% 14 Missing ⚠️
cmd/exit_broadcast.go 0.00% 1 Missing ⚠️
cmd/exit_fetch.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3057      +/-   ##
==========================================
- Coverage   54.63%   54.62%   -0.01%     
==========================================
  Files         207      207              
  Lines       29145    29150       +5     
==========================================
+ Hits        15922    15924       +2     
- Misses      11383    11387       +4     
+ Partials     1840     1839       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gsora gsora changed the title cmd: exit sign UX tweak cmd: exit UX tweak Apr 29, 2024
@gsora gsora requested a review from OisinKyne April 29, 2024 14:47
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gsora gsora added the merge when ready Indicates bulldozer bot may merge when all checks pass label Apr 30, 2024
@obol-bulldozer obol-bulldozer bot merged commit a30d5cb into main Apr 30, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the gsora/exit-sign-keystore-ux-fix branch April 30, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants