app/eth2wrap: sign domain for VOLUNTARY_EXIT
#3035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of returning the latest Domain available when the DomainName requested is VOLUNTARY_EXIT, returns the Capella one as detailed in EIP-7044. Doing so fixes both `exit` commands generating wrong signatures and voluntary exits sent over the VC.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3035 +/- ##
==========================================
- Coverage 54.80% 54.75% -0.06%
==========================================
Files 206 207 +1
Lines 28837 28932 +95
==========================================
+ Hits 15805 15842 +37
- Misses 11213 11269 +56
- Partials 1819 1821 +2 ☔ View full report in Codecov by Sentry. |
pinebit
approved these changes
Apr 11, 2024
|
@pinebit why do you think that? Do you believe we should hold off this PR until V3 is merged? |
gsora
changed the title
VOLUNTARY_EXITVOLUNTARY_EXIT
|
Okay then, merging! |
gsora
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning the latest Domain available when the DomainName requested is VOLUNTARY_EXIT, returns the Capella one as detailed in EIP-7044.
Doing so fixes both
exitcommands generating wrong signatures and voluntary exits sent over the VC.category: bug
ticket: #2981
Closes #2981.