Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: logging lock hash and enr #2972

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Conversation

pinebit
Copy link
Contributor

@pinebit pinebit commented Mar 18, 2024

Added logging of full lock_hash and node's enr when charon starts.

category: refactor
ticket: #2778

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 54.19%. Comparing base (08e0920) to head (5920793).
Report is 2 commits behind head on main.

Files Patch % Lines
app/app.go 0.00% 7 Missing ⚠️
cmd/dkg.go 0.00% 1 Missing ⚠️
cmd/relay.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2972      +/-   ##
==========================================
+ Coverage   54.11%   54.19%   +0.07%     
==========================================
  Files         195      195              
  Lines       27551    27564      +13     
==========================================
+ Hits        14910    14937      +27     
+ Misses      10880    10868      -12     
+ Partials     1761     1759       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

app/app.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Mar 19, 2024
@obol-bulldozer obol-bulldozer bot merged commit d076076 into main Mar 19, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/logging-lock-hash-enr branch March 19, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants