app/health: app_health_metrics_high_cardinality #2967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with compose (simnet) cluster. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2967 +/- ##
==========================================
- Coverage 54.24% 54.22% -0.02%
==========================================
Files 195 195
Lines 27510 27551 +41
==========================================
+ Hits 14922 14939 +17
- Misses 10833 10850 +17
- Partials 1755 1762 +7 ☔ View full report in Codecov by Sentry. |
|
Is this metric impacted by the amount of validators in the cluster? |
Indeed, I forgot about the fact the threshold shall depend on number of validators. Now fixed. |
|
gsora
approved these changes
Mar 15, 2024
KaloyanTanev
approved these changes
Mar 16, 2024
pinebit
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to monitor metrics high cardinality, when a given metric gets too many distinct labels which results in high memory consumption in charon.
To this end this PR introduces one new metric:
app_health_metrics_high_cardinality(gauge) which renders metric names => max labels count, if this metric exceeded the threshold (100 * num_of_validators).In addition to the above metric which can be used in alerting, this also adds a new "health check" named
metrics_high_cardinalitywhich is triggered whenapp_health_metrics_high_cardinalityreported any offense.Note:
app_health_metrics_high_cardinalitywill not "reset", because the purpose of this feature is to detect and signal an opportunity of memory leak.category: feature
ticket: #2446