Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: remove todo #2957

Merged
merged 1 commit into from
Mar 14, 2024
Merged

core: remove todo #2957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions core/consensus/transport.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import (
"google.golang.org/protobuf/types/known/timestamppb"

"github.com/obolnetwork/charon/app/errors"
"github.com/obolnetwork/charon/app/log"
"github.com/obolnetwork/charon/core"
pbv1 "github.com/obolnetwork/charon/core/corepb/v1"
"github.com/obolnetwork/charon/core/qbft"
Expand Down Expand Up @@ -144,11 +143,6 @@ func (t *transport) ProcessReceives(ctx context.Context, outerBuffer chan msg) {
case <-ctx.Done():
return
case msg := <-outerBuffer:
if err := validateMsg(msg); err != nil {
log.Warn(ctx, "Dropping invalid message", err)
continue
}

t.setValues(msg)

select {
Expand Down Expand Up @@ -196,12 +190,6 @@ func createMsg(typ qbft.MsgType, duty core.Duty,
return newMsg(pbMsg, justMsgs, values)
}

// validateMsg returns an error if the message is invalid.
func validateMsg(_ msg) error {
// TODO(corver): implement (incl signature verification).
return nil
}

// newSniffer returns a new sniffer.
func newSniffer(nodes, peerIdx int64) *sniffer {
return &sniffer{
Expand Down
Loading